Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convention test for preview APIs #2154

Merged
merged 12 commits into from
Mar 18, 2020
Merged

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 15, 2020

This PR reviews and marks the preview headers that are no longer currently documented on the GitHub Developer site.

  • add test
  • mark headers that are now out of scope
  • cleanup APIs that have graduated

@shiftkey shiftkey force-pushed the conventions-for-previews-tests branch from af17693 to 46215ea Compare March 15, 2020 19:24
@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #2154 into master will decrease coverage by 0.00%.
The diff coverage is 92.81%.

@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
- Coverage   66.73%   66.72%   -0.01%     
==========================================
  Files         545      545              
  Lines       14233    14232       -1     
==========================================
- Hits         9498     9497       -1     
  Misses       4735     4735              
Impacted Files Coverage Δ
Octokit/Helpers/AcceptHeaders.cs 100.00% <ø> (ø)
...t.Reactive/Clients/ObservableRepositoriesClient.cs 68.38% <50.00%> (ø)
Octokit.Reactive/Clients/ObservableTeamsClient.cs 50.00% <50.00%> (ø)
Octokit/Clients/MiscellaneousClient.cs 71.42% <50.00%> (ø)
Octokit/Clients/RepoCollaboratorsClient.cs 76.13% <50.00%> (ø)
Octokit/Clients/TeamsClient.cs 84.26% <93.33%> (ø)
...t.Reactive/Clients/ObservableIssuesLabelsClient.cs 93.68% <100.00%> (ø)
...ctive/Clients/ObservableRepoCollaboratorsClient.cs 76.00% <100.00%> (ø)
...e/Clients/ObservableRepositoryInvitationsClient.cs 100.00% <100.00%> (ø)
Octokit/Clients/CommitsClient.cs 100.00% <100.00%> (ø)
... and 13 more

@shiftkey shiftkey merged commit 3270207 into master Mar 18, 2020
@shiftkey shiftkey deleted the conventions-for-previews-tests branch March 18, 2020 11:52
@shiftkey
Copy link
Member Author

release_notes: Clean up preview accept headers which are no longer documented or have graduated to production.

@shiftkey
Copy link
Member Author

shiftkey commented Mar 26, 2020

advisories: This release stops sending preview accept headers which are no longer mentioned in the developer documentation. These features should be working as expected if the service no longer looks for the preview header, but if you spot a situation where the code is not returning the expected response as it was in previous releases please open an issue so we can investigate.

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants