Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ReleasesClientTests.TheCreateReleasesMethod tests as integration #2152

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Mar 13, 2020

They were using [Fact] instead of [IntegrationTest] so they would run and fail if no credentials are supplied.

They were using [Fact] instead of [IntegrationTest] so they would run and fail if no credentials are supplied.
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #2152 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2152   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files         544      544           
  Lines       14234    14234           
=======================================
  Hits         9512     9512           
  Misses       4722     4722           

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find - thanks for submitting @0xced!

@shiftkey shiftkey merged commit 3918685 into octokit:master Mar 13, 2020
@0xced 0xced deleted the fix-integration-tests branch March 13, 2020 18:46
@shiftkey
Copy link
Member

release_notes: mark ReleasesClientTests.TheCreateReleasesMethod tests as integration

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants