Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated code for old Check Suites API #2130

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 5, 2020

Fixes #2127

This removes code that was marked as obsolete back in v0.32.0 and can be removed as the last supported version of GitHub Enterprise (2.14) was only supported up until July 2019.

@shiftkey shiftkey force-pushed the tidy-up-obsolete-apis branch from 09895b1 to 9e2f7f2 Compare March 5, 2020 12:58
@shiftkey shiftkey force-pushed the tidy-up-obsolete-apis branch from 9e2f7f2 to bf4a2c4 Compare March 5, 2020 13:01
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #2130 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2130      +/-   ##
==========================================
- Coverage    66.9%   66.84%   -0.06%     
==========================================
  Files         543      543              
  Lines       14252    14230      -22     
==========================================
- Hits         9535     9512      -23     
- Misses       4717     4718       +1
Impacted Files Coverage Δ
Octokit/Helpers/ApiUrls.cs 97.96% <ø> (-0.01%) ⬇️
...it.Reactive/Clients/ObservableCheckSuitesClient.cs 100% <ø> (ø) ⬆️
Octokit/Clients/CheckSuitesClient.cs 90.32% <ø> (+0.84%) ⬆️
Octokit/Models/Request/CheckSuiteTriggerRequest.cs 0% <0%> (-60%) ⬇️

@shiftkey shiftkey merged commit 43d1b8b into master Mar 5, 2020
@shiftkey shiftkey deleted the tidy-up-obsolete-apis branch March 5, 2020 13:14
@shiftkey
Copy link
Member Author

release_notes: removed obsolete code for CheckSuitesClient

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup obsolete APIs only available GitHub Enterprise 2.14
2 participants