Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add attribute for tracking preview usage in the codebase #2128

Merged
merged 22 commits into from
Mar 7, 2020

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 5, 2020

Review the codebase for each of the previews from https://developer.github.com/v3/previews/ :

  • add attribute usage for each place in the codebase
  • review usage matches the documentation

OR

  • open an issue to track supporting the preview API

Current preview support:

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #2128 into master will decrease coverage by 0.00%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #2128      +/-   ##
==========================================
- Coverage   66.84%   66.83%   -0.01%     
==========================================
  Files         543      544       +1     
  Lines       14230    14234       +4     
==========================================
+ Hits         9512     9514       +2     
- Misses       4718     4720       +2     
Impacted Files Coverage Δ
Octokit/Helpers/PreviewAttribute.cs 0.00% <0.00%> (ø)
Octokit/SimpleJson.cs 70.41% <0.00%> (+0.26%) ⬆️

@shiftkey shiftkey force-pushed the audit-preview-api-usage branch 2 times, most recently from d23dda8 to 66f3ab9 Compare March 6, 2020 13:11
@shiftkey shiftkey force-pushed the audit-preview-api-usage branch from 66f3ab9 to 50ef496 Compare March 6, 2020 13:31
@shiftkey shiftkey force-pushed the audit-preview-api-usage branch from dc280a0 to 7bd9c07 Compare March 6, 2020 21:56
@shiftkey shiftkey marked this pull request as ready for review March 7, 2020 14:39
@shiftkey shiftkey merged commit 5de5258 into master Mar 7, 2020
@shiftkey shiftkey deleted the audit-preview-api-usage branch March 7, 2020 14:40
@shiftkey
Copy link
Member Author

shiftkey commented Mar 7, 2020

release_notes: Added preview header for OAuth Applications API changes that were overlooked in #2116 in readiness for eventual deprecation

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants