-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ProjectCard attribute to events model #2102
Add ProjectCard attribute to events model #2102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2102 +/- ##
=========================================
- Coverage 67.05% 67% -0.06%
=========================================
Files 538 539 +1
Lines 14141 14185 +44
=========================================
+ Hits 9482 9504 +22
- Misses 4659 4681 +22
|
@shiftkey , could you please take a look at this PR? |
This is fine. I think I need to tweak the Codecov settings to focus on certain namespaces over others.
I am not sure about this either, and need to check the history to understand why these are different. |
@shiftkey , I believe that my change is safe enough because:
As you can see,
I have changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxim-lobanov this is looking really great - thanks for the contribution.
Only bit of feedback I have is about updating the tests to assert on the preview accept header, everything else looks great!
release_notes: added |
Hello!
I have faced with issue that Event model doesn't contain
project_card
property that is important for all events that are related to GitHub boards (Projects).For example, for event
added_to_project
, it contains the name of column where issue is added.For event
moved_columns_in_project
, it contains the previous and new column names.This PR includes the following changes:
EventInfo
model toIssueEvent
(please see note below for details)IssueEventProjectCard
accordingly to GitHub API descriptionIssueEventsApiPreview = "application/vnd.github.starfox-preview"
that is needed to getproject_card
valueOctokit.Reactive
with the same changesNote: Why
EventInfo
model was replaced byIssueEvent
inIssueClient
:These models are pretty similar but
IssueEvent
contains additional fields likeIssue
andProjectCard
.I am not sure why some methods in
IssueClient
usedIssueEvent
but some methods usedEventInfo
. Based on API, all methods inIssueClient
should useIssueEvent
.