Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale check conclusion #2080

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Add stale check conclusion #2080

merged 1 commit into from
Feb 4, 2020

Conversation

BenEmdon
Copy link
Contributor

@BenEmdon BenEmdon commented Feb 4, 2020

Hey Dotnet SDK team 👋

I work on the team which maintains checks at GitHub and I wanted to add this conclusion ahead of release. This check conclusion will be fully documented on release.

I would also like to note that we could add new check/status states at any time, since adding states would be an additive change. The client-side logic should reflect this in some way so that new states don't break integrators systems.

@BenEmdon BenEmdon requested a review from a team February 4, 2020 00:29
@shiftkey
Copy link
Member

shiftkey commented Feb 4, 2020

The client-side logic should reflect this in some way so that new states don't break integrators systems.

Yep, for states that we don't know they'll fallback to null until we add them.

@BenEmdon
Copy link
Contributor Author

BenEmdon commented Feb 4, 2020

@shiftkey Yep, for states that we don't know they'll fallback to null until we add them.

Good to know! Apologies for my wrong assumption, I am not accustomed to the codebase 😅

@shiftkey
Copy link
Member

shiftkey commented Feb 4, 2020

@BenEmdon no problem - totally understandable!

@shiftkey shiftkey merged commit 2d0124f into octokit:master Feb 4, 2020
@BenEmdon BenEmdon deleted the patch-1 branch February 4, 2020 00:34
@shiftkey
Copy link
Member

shiftkey commented Feb 4, 2020

release_notes: Add CheckConclusion.Stale value to Conclusion property for CheckSuite and CheckRun

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #2080 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2080   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files         538      538           
  Lines       14138    14138           
=======================================
  Hits         9481     9481           
  Misses       4657     4657

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants