Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the undocumented (but used) check suite conclusion "skipped" #2077

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

JeffreyPalmer
Copy link
Contributor

Hello!

There is currently an undocumented check suite conclusion ("skipped") that exists in the wild (see https://github.community/t5/GitHub-API-Development-and/Is-quot-skipped-quot-now-a-valid-check-suite-conclusion/m-p/43980#M3900) that causes this library to throw an exception while attempting to load check suites with that conclusion. Since I can't seem to get an answer as to whether or not this has been added to the Checks API, I'm assuming that it has and that this is a documentation deficiency. I'm therefore submitting this trivial PR to add it. Unfortunately I don't think that I was able to run all of the tests (I'm not on Windows) - hope that's okay.

Additionally, do you have any plans to release another version soon? In addition to this issue, I would love to have access to the organization membership methods that were added two commits after v0.36.0. Thanks!

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #2077 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2077   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files         538      538           
  Lines       14138    14138           
=======================================
  Hits         9481     9481           
  Misses       4657     4657

@shiftkey
Copy link
Member

Thanks for the contribution!

Additionally, do you have any plans to release another version soon? In addition to this issue, I would love to have access to the organization membership methods that were added two commits after v0.36.0. Thanks!

This is on my list to do sometime in the next couple weeks - I just need a reliable working environment to publish releases and get the release notes written.

@shiftkey shiftkey merged commit 321c9ba into octokit:master Jan 28, 2020
@shiftkey
Copy link
Member

shiftkey commented Feb 3, 2020

release_notes: add CheckConclusion.Skipped value to Conclusion property for CheckSuite and CheckRun

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants