Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose affiliation parameter when listing collaborators #2043

Merged
merged 6 commits into from
Nov 18, 2019

Conversation

hnrkndrssn
Copy link
Contributor

Also adds support for the Nested Teams preview API

Fixes #2036

@codecov
Copy link

codecov bot commented Nov 9, 2019

Codecov Report

Merging #2043 into master will increase coverage by 0.06%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##           master    #2043      +/-   ##
==========================================
+ Coverage   70.73%   70.79%   +0.06%     
==========================================
  Files         537      538       +1     
  Lines       14106    14139      +33     
==========================================
+ Hits         9978    10010      +32     
- Misses       4128     4129       +1
Impacted Files Coverage Δ
...ctokit/Models/Request/SearchRepositoriesRequest.cs 76.69% <100%> (ø) ⬆️
Octokit/Clients/RepoCollaboratorsClient.cs 76.13% <100%> (+4.51%) ⬆️
Octokit/Models/Request/SearchIssuesRequest.cs 91.89% <100%> (ø) ⬆️
Octokit/Models/Request/SearchCodeRequest.cs 92.72% <100%> (ø) ⬆️
...ctive/Clients/ObservableRepoCollaboratorsClient.cs 76% <100%> (+5.5%) ⬆️
...it/Models/Request/SearchIssuesRequestExclusions.cs 97.72% <100%> (ø) ⬆️
Octokit/Models/Request/SearchUsersRequest.cs 96.77% <100%> (ø) ⬆️
...odels/Request/RepositoryCollaboratorListRequest.cs 80% <80%> (ø)

@shiftkey
Copy link
Member

@hnrkndrssn I'm feeling pretty good with how this looks. Anything you're waiting on?

@hnrkndrssn
Copy link
Contributor Author

Anything you're waiting on?

I was going to write some tests for it, just got side tracked with life-stuff :) I'll try to get those last little things in tonight and mark the PR ready for review once done 👍

@shiftkey
Copy link
Member

@hnrkndrssn
Copy link
Contributor Author

@hnrkndrssn hnrkndrssn marked this pull request as ready for review November 15, 2019 08:12
@shiftkey shiftkey self-requested a review November 18, 2019 11:07
@shiftkey shiftkey self-assigned this Nov 18, 2019
Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @hnrkndrssn for the contribution!

@shiftkey shiftkey merged commit a05d49e into octokit:master Nov 18, 2019
@shiftkey
Copy link
Member

shiftkey commented Feb 3, 2020

release_notes: add support for filtering repository collaborators by their affiliation

@Jacobtarango21
Copy link

image

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List collaborators does not expose the affiliation parameter (or preview API)
4 participants