fix language with spaces giving wrong results [#1607] #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dagizmo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
=======================================
Coverage 70.73% 70.73%
=======================================
Files 537 537
Lines 14106 14106
=======================================
Hits 9978 9978
Misses 4128 4128
|
|
@Dagizmo I think the only thing that's missing from this PR is a test that verifies we send through the space in the correct way (I don't think we need to encode it as |
|
ok, will look into that. |
Dagizmo
commented
Nov 1, 2019
| @@ -117,7 +117,7 @@ public override IReadOnlyList<string> MergedQualifiers() | |||
|
|
|||
| if (Language != null) | |||
| { | |||
| parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:\"{0}\"", Language)); | |||
| parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:\"{0}\"", Language.ToParameter())); | |||
There was a problem hiding this comment.
Actually found that this part didn't use to Parameter so named languages such as CPlusPlus was parsed as "CPlusPlus" instead of "cpp"
|
updated :D |
|
release_notes: address encoding of spaces when using Search API |
nickfloyd
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1607