Implementation of Search Api #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Octokit/Helpers/ApiUrls.cs
Change the `DeleteAsync` method to return `Task<IResponse<object>>` in order to check the status code
Fix test for issues.update
* Add all `StarredClient` methods to the interface * Add xml doc comments * Correct parameter names
…love Xamarin Studio Builds Again
|
@shiftkey looks like this PR needs to be closed and open a new one that will get merged into master? I am merging my changes onto the incorrect branch? How do you want me to do this? Thanks |
|
@shiftkey what do you want me to do about: #203 (comment) ? |
|
That rebase looks real ugly... Something went 💥 |
|
@hahmed my psychic debugger thinks you need to get master up to date before doing the rebase |
|
replaced with #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to merge all of these into the pr #189
done something wrong here.
By the way - I have 3 failing tests.
Search Repo
Search Code
Search Issues
Note sure why?
http://developer.github.com/v3/search/
#137