-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for multiple extension filters #2019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
+ Coverage 70.77% 70.77% +<.01%
==========================================
Files 535 535
Lines 14062 14063 +1
==========================================
+ Hits 9952 9953 +1
Misses 4110 4110
|
@ecarlson94 not that I'm aware of. Please open one if this is something you'd like to see it supported. |
@ecarlson94 thanks for opening this up. I also know there's a docs example in var request = new SearchCodeRequest("auth")
{
// we can restrict search to the file, path or search both
In = new[] { CodeInQualifier.File, CodeInQualifier.Path },
// how about we find a file based on a certain language
Language = Language.JavaScript,
// do we want to search forks too?
Forks = true,
// find files that are above 1000 bytes
Size = Range.GreaterThan(1000),
// we may want to restrict the search to the path of a file
Path = "app/assets",
// we may want to restrict the file based on file extension
Extension = "json",
// restrict search to a specific file name
FileName = "app.json",
// search within a users or orgs repo
User = "dhh"
}; |
@shiftkey, thanks for the quick response. I updated the documentation. Sorry I missed it. I also changed the |
@shiftkey, any idea what I should do about this Travis CI error. |
@ecarlson94 it's unrelated to the PR, so I've just re-run it to see if it'll pass |
release_notes: |
Modifies
SearchCodeRequest.Extension
to be a list for filtering byx
number of extensions. Helps reduce the number of required API calls.Question: Is there an open issue to support the negation of qualifiers (
-extension:{0}
)? I couldn't find one.