Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin implementation of Enterprise ManagementConsole API, redux #2010

Merged
merged 29 commits into from
Sep 22, 2019
Merged

Begin implementation of Enterprise ManagementConsole API, redux #2010

merged 29 commits into from
Sep 22, 2019

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Sep 22, 2019 •
edited
Loading

Supersedes #1269 which predates a lot of nice things:

  • the cleanup of csproj files
  • maintainers being able to push to PR branches (so I can rebase the work)

This felt close enough, but it's been a few years so I'm gonna need time to read it over again.

  • builds and tests pass
  • review changes and tests make sense
  • add some docs
  • tidy up diff

@shiftkey shiftkey mentioned this pull request Sep 22, 2019
Closed
@shiftkey shiftkey self-assigned this Sep 22, 2019
@codecov
Copy link

codecov bot commented Sep 22, 2019 •
edited
Loading

Codecov Report

Merging #2010 into master will decrease coverage by 0.06%.
The diff coverage is 51.28%.

@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
- Coverage   70.85%   70.78%   -0.07%     
==========================================
  Files         529      535       +6     
  Lines       13961    14062     +101     
==========================================
+ Hits         9892     9954      +62     
- Misses       4069     4108      +39
Impacted Files Coverage Δ
...okit/Models/Response/Enterprise/AdminStatsPulls.cs 0% <0%> (ø) ⬆️
...kit/Models/Response/Enterprise/LdapSyncResponse.cs 0% <0%> (ø) ⬆️
Octokit/Helpers/ReferenceExtensions.cs 0% <0%> (ø) ⬆️
...els/Response/Enterprise/MaintenanceModeResponse.cs 0% <0%> (ø)
...e/Clients/Enterprise/ObservableEnterpriseClient.cs 0% <0%> (ø) ⬆️
...okit/Models/Response/Enterprise/AdminStatsHooks.cs 0% <0%> (ø) ⬆️
...okit/Models/Response/Enterprise/AdminStatsGists.cs 0% <0%> (ø) ⬆️
...okit/Models/Response/Enterprise/AdminStatsRepos.cs 0% <0%> (ø) ⬆️
...dels/Response/Enterprise/SearchIndexingResponse.cs 0% <0%> (ø) ⬆️
...okit/Models/Response/Enterprise/AdminStatsPages.cs 0% <0%> (ø) ⬆️
... and 21 more

@shiftkey shiftkey mentioned this pull request Sep 22, 2019
Closed
6 tasks
ryangribble and others added 25 commits September 22, 2019 13:45
@ryangribble @shiftkey
Initial implementation of ManagementConsole - maintenance mode
e657c3c
@ryangribble @shiftkey
Add environment var support for management console password for integ…
98a9418 
…ration tests
@ryangribble @shiftkey
Add reactive client and unit tests
30c38a6
@ryangribble @shiftkey
Update some xmlDoc
b25ae6f
@ryangribble @shiftkey
I think this is a better way to setup the underlying baseUri on IConn…
5f68f0e 
…eciton, to achieve managemet console access rather than requiring a specific GitHubClient that cant call normal API's

Instead, the management client methods can check the base Url and if it contains /api/v3/ they can set their relative endpoint Uri to include a leading "/" which will cause the /api/v3/ to be removed.
@ryangribble @shiftkey
Update EnterpriseClient.cs
afac8f9 
Fix xml comments
@ryangribble @shiftkey
Update IEnterpriseClient.cs
b37e1b4 
Fix xml comments
@ryangribble @shiftkey
Still trying to get the xmDoc perfect, thanks app veyor :)
7af8ef9
@ryangribble @shiftkey
XmlDoc'ing my way to success
5388c48
@ryangribble @shiftkey
Add specific test attribute for management console tests
7383fdf
@ryangribble @shiftkey
check chronic string empty/null
2f04e4e
@ryangribble @shiftkey
Use helper's password field in test
a833dbe
@ryangribble @shiftkey
Tidy up maintenance mode tests by using a context/destructor to manag…
1e6143b 
…e the initial/end state of maintenance mode
@ryangribble @shiftkey
make internal and tidy up URL concatenation
dc5b9eb
@ryangribble @shiftkey
move GHE endpoint fixup inside ApiUrls methods
81023e4
@ryangribble @shiftkey
Rework request object to be the correct structure so SimpleJsonSerial…
b581b4b 
…izer can be used to serialize it. Remove MaintenanceDate class and just pass in the Date/string for when

Still need to use UrlFormEncoding rather than json in the POST body though...
@ryangribble @shiftkey
Create abstract base class for FormUrlEncoded parameters (similar to …
4f859e3 
…existing RequetParameters) and inherit from it in UpdateMaintenanceRequest
@ryangribble @shiftkey
Fix maintenance context logic - destructor should always turn mainten…
67d044d 
…ance OFF regardless of initial requested state
@ryangribble @shiftkey
Fix xml comment
05eb9c0
@ryangribble @shiftkey
Fix Xml comment
66c5b25
@ryangribble @shiftkey
Those pesky xml comments!
c359466
@ryangribble @shiftkey
Fine, I give up!
0446924
@ryangribble @shiftkey
Fix string.Format
02d8763
@shiftkey
fix bad rebase
0216b6d
@shiftkey
fix failing convention tests
dcbbf60
@shiftkey shiftkey force-pushed the maintenance-work-rebased branch from 6004993 to 43914e5 Compare September 22, 2019 16:46
shiftkey
shiftkey commented Sep 22, 2019
View reviewed changes
Copy link
Member Author

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried that this was our first Enterprise-specific APIs but it turns out there's a bunch and I just don't remember them. Gonna merge this in and then tackle #2011

@shiftkey shiftkey merged commit 8cd0b34 into master Sep 22, 2019
@shiftkey shiftkey deleted the maintenance-work-rebased branch September 22, 2019 18:10
@shiftkey
Copy link
Member Author

release_notes: added Management Console API to view and edit maintenance mode

This was referenced Sep 22, 2019
Merged
Merged
@nickfloyd nickfloyd added Type: Feature New feature or request and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shiftkey shiftkey

Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiftkey @nickfloyd @ryangribble