Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NSubstitute from 3.1.0 to 4.2.1 #1993

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Bump NSubstitute from 3.1.0 to 4.2.1 #1993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2fb058
Bump NSubstitute from 3.1.0 to 4.2.1
dependabot-preview[bot] Sep 16, 2019
62135b1
fix failing tests
shiftkey Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Octokit.Tests/Http/ApiConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ public async Task WhenGetReturnsOkThenBodyAsObjectIsReturned()
.Returns(Task.FromResult(response));
var apiConnection = new ApiConnection(connection);

var actualResult = await apiConnection.GetQueuedOperation<object>(queuedOperationUrl, Args.CancellationToken);
var actualResult = await apiConnection.GetQueuedOperation<object>(queuedOperationUrl, CancellationToken.None);
Assert.Same(actualResult, result);
}

Expand All @@ -361,7 +361,7 @@ public async Task WhenGetReturnsNoContentThenReturnsEmptyCollection()
.Returns(Task.FromResult(response));
var apiConnection = new ApiConnection(connection);

var actualResult = await apiConnection.GetQueuedOperation<object>(queuedOperationUrl, Args.CancellationToken);
var actualResult = await apiConnection.GetQueuedOperation<object>(queuedOperationUrl, CancellationToken.None);
Assert.Empty(actualResult);
}

Expand Down
2 changes: 1 addition & 1 deletion Octokit.Tests/Octokit.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<ItemGroup>
<ProjectReference Include="..\Octokit\Octokit.csproj" />
<ProjectReference Include="..\Octokit.Reactive\Octokit.Reactive.csproj" />
<PackageReference Include="NSubstitute" Version="3.1.0" />
<PackageReference Include="NSubstitute" Version="4.2.1" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.0' ">
Expand Down