Organization Membership Preview API Changes - existing endpoints #1952
Conversation
hnrkndrssn
force-pushed
the
organization-membership-preview
branch
2 times, most recently
from
fd88e95 to
faa6d0f
Compare
hnrkndrssn
force-pushed
the
organization-membership-preview
branch
from
faa6d0f to
8e8f4af
Compare
There was a problem hiding this comment.
Hey @hnrkndrssn this looks pretty awesome thanks. I noted a couple of things
Octokit.sln.DotSettings
Outdated
| @@ -269,6 +269,7 @@ II.2.12 <HandlesEvent />
 | |||
| <s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpKeepExistingMigration/@EntryIndexedValue">True</s:Boolean> | |||
| <s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpPlaceEmbeddedOnSameLineMigration/@EntryIndexedValue">True</s:Boolean> | |||
| <s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpRenamePlacementToArrangementMigration/@EntryIndexedValue">True</s:Boolean> | |||
| <s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpUseContinuousIndentInsideBracesMigration/@EntryIndexedValue">True</s:Boolean> | |||
There was a problem hiding this comment.
can you clarify what this resharper setting does?
There was a problem hiding this comment.
Hmm...I think this was an involentary change...
| /// <summary> | ||
| /// Gets or sets the default permission level members have for organization repositories. | ||
| /// </summary> | ||
| public string DefaultRepositoryPermission { get; set; } |
There was a problem hiding this comment.
should this be an enum?
| /// <summary> | ||
| /// Default permission level members have for organization repositories. | ||
| /// </summary> | ||
| public string DefaultRepositoryPermission { get; protected set; } |
There was a problem hiding this comment.
should this be a StringEnum<T> ?
|
I also noticed while reviewing that there is another API preview involving a new field |
| @@ -10,12 +10,13 @@ public class Organization : Account | |||
| { | |||
| public Organization() { } | |||
|
|
|||
| public Organization(string avatarUrl, string bio, string blog, int collaborators, string company, DateTimeOffset createdAt, int diskUsage, string email, int followers, int following, bool? hireable, string htmlUrl, int totalPrivateRepos, int id, string nodeId, string location, string login, string name, int ownedPrivateRepos, Plan plan, int privateGists, int publicGists, int publicRepos, string url, string billingAddress, string defaultRepositoryPermission, bool membersCanCreateRepositories) | |||
| public Organization(string avatarUrl, string bio, string blog, int collaborators, string company, DateTimeOffset createdAt, int diskUsage, string email, int followers, int following, bool? hireable, string htmlUrl, int totalPrivateRepos, int id, string nodeId, string location, string login, string name, int ownedPrivateRepos, Plan plan, int privateGists, int publicGists, int publicRepos, string url, string billingAddress, string defaultRepositoryPermission, bool membersCanCreateRepositories, string membersAllowedRepositoryCreationType) | |||
There was a problem hiding this comment.
defaultRepositoryPermission and membersAllowedRepositoryCreationType are strings in the ctor rather than the enum types. Although this does compile, we should take the enum type in the ctor for consistency/clarity
|
👋 Hey Friends, this pull request has been automatically marked as |
Fixes #1514