Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination support to Reactions Clients #1948

Merged
merged 14 commits into from
Feb 27, 2019
Merged

Pagination support to Reactions Clients #1948

merged 14 commits into from
Feb 27, 2019

Conversation

hnrkndrssn
Copy link
Contributor

@hnrkndrssn hnrkndrssn commented Feb 21, 2019 •
edited
Loading

  • ICommitCommentReactionsClient
  • IObservableCommitCommentReactionsClient
  • IIssueCommentReactionsClient
  • IObservableIssueCommentReactionsClient
  • IIssueReactionsClient
  • IObservableIssueReactionsClient
  • IPullRequestReviewCommentReactionsClient
  • IObservablePullRequestReviewCommentReactionsClient

Fixes #1661

@hnrkndrssn hnrkndrssn changed the title [WIP] Pagination support to Reactions Clients Pagination support to Reactions Clients Feb 22, 2019
@ryangribble
Copy link
Contributor

Welcome back @hnrkndrssn!

I'll have a 👀 when I can

@hnrkndrssn
Copy link
Contributor Author

Thanks @ryangribble, no rush 😃

ryangribble
ryangribble reviewed Feb 24, 2019
View reviewed changes
Copy link
Contributor

@ryangribble ryangribble left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty minor nitpick, but we are missing null check tests for the overloads that take a repositoryId, and ApiOptions. Probably because until now there were no null checks for the repositoryId/GetAll methods since they had no nullable parameters, thus there was no existing section to add a check to...

@ryangribble
Copy link
Contributor

ryangribble commented Feb 24, 2019 •
edited
Loading

release_notes: Added pagination support to CommitCommentReactionsClient, IssueCommentReactionsClient, IssueReactionsClient and PullRequestReviewCommentReactionsClient

@ryangribble
Copy link
Contributor

@ryangribble ryangribble merged commit 43381c4 into octokit:master Feb 27, 2019
@hnrkndrssn hnrkndrssn deleted the reactions-pagination branch February 27, 2019 19:53
@nickfloyd nickfloyd added Type: Feature New feature or request and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryangribble ryangribble ryangribble left review comments

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
Missing Pagination Support
Development

Successfully merging this pull request may close these issues.
3 participants
@hnrkndrssn @ryangribble @nickfloyd