Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle event ids greater than int32.maxvalue #1940

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Handle event ids greater than int32.maxvalue #1940

merged 1 commit into from
Feb 19, 2019

Conversation

matt-richardson
Copy link
Contributor

Fixes #1939

Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ryangribble
Copy link
Contributor

Thanks @matt-richardson

LGTM

@ryangribble ryangribble merged commit 3147ddd into octokit:master Feb 19, 2019
@matt-richardson
Copy link
Contributor Author

Thanks for the quick response. Whats your thoughts around when this could make it into a release?

@ryangribble
Copy link
Contributor

I've been meaning to push a release already however there wasn't anything that was urgent/pressing. This PR changes that though so I'll try to do it in the next few days.

In the meantime you can pull the package built from merging this PR from our appveyor nuget feed if you need to get back up and running 👍

@ryangribble
Copy link
Contributor

release_notes: Update EventInfo.Id field from int to long to prevent overflow exceptions

@adamralph
Copy link
Contributor

Any update on getting this released? We're currently blocked on this over at https://github.com/Particular

@hnrkndrssn
Copy link
Contributor

hnrkndrssn commented Apr 4, 2019

@adamralph you could use the beta package https://github.com/octokit/octokit.net/blob/master/README.md#beta-packages

That's how we unblocked ourselves while waiting for the next release.

But that might not be an option or the ideal solution...

@adamralph
Copy link
Contributor

@hnrkndrssn in our case, we're using LINQPad scripts, and unfortunately we can't bake a package source into the script definitions.

@Eilon
Copy link
Contributor

Eilon commented May 24, 2019

I just hit this as well with some events with IDs greater than int.MaxValue. Would love to see a public release that has this fix!

@Thraka
Copy link

Thraka commented Oct 17, 2019

I just ran into this issue too.

var results = await client.Issue.Events.GetAllForRepository("dotnet", "docs");

Using octokit 0.36.0

@shiftkey
Copy link
Member

@Thraka please open a new issue as I suspect that requires a different fix to what was addressed in this PR.

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieving events for issue throws System.OverflowException
8 participants