-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle event ids greater than int32.maxvalue #1940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Thanks @matt-richardson |
Thanks for the quick response. Whats your thoughts around when this could make it into a release? |
I've been meaning to push a release already however there wasn't anything that was urgent/pressing. This PR changes that though so I'll try to do it in the next few days. In the meantime you can pull the package built from merging this PR from our appveyor nuget feed if you need to get back up and running 👍 |
release_notes: Update |
Any update on getting this released? We're currently blocked on this over at https://github.com/Particular |
@adamralph you could use the beta package https://github.com/octokit/octokit.net/blob/master/README.md#beta-packages That's how we unblocked ourselves while waiting for the next release. But that might not be an option or the ideal solution... |
@hnrkndrssn in our case, we're using LINQPad scripts, and unfortunately we can't bake a package source into the script definitions. |
I just hit this as well with some events with IDs greater than int.MaxValue. Would love to see a public release that has this fix! |
I just ran into this issue too. var results = await client.Issue.Events.GetAllForRepository("dotnet", "docs"); Using octokit 0.36.0 |
@Thraka please open a new issue as I suspect that requires a different fix to what was addressed in this PR. |
Fixes #1939