Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't apply Tls1.2 workaround when .NET 4.7 SystemDefault is set #1936

Merged
merged 5 commits into from
Feb 27, 2019

Conversation

ryangribble
Copy link
Contributor

Fixes #1914

Don't touch SecurityProtocol when current value is the new SystemDefault added in .NET 4.7

Added comment to explain what we are doing

…ed in .NET 4.7

Add comment to explain what we are doing
@ryangribble
Copy link
Contributor Author

ryangribble commented Jan 31, 2019

release_notes: Prevent previous Tls1.2 fix for earlier frameworks from interfering with .NET 4.7+ SecurityProtocolType.SystemDefault configuration

Octokit/Http/HttpClientAdapter.cs Outdated Show resolved Hide resolved
Octokit/Http/HttpClientAdapter.cs Outdated Show resolved Hide resolved
Octokit/Http/HttpClientAdapter.cs Outdated Show resolved Hide resolved
Octokit/Http/HttpClientAdapter.cs Outdated Show resolved Hide resolved
@ryangribble ryangribble merged commit 6385e2d into master Feb 27, 2019
@ryangribble ryangribble deleted the tls branch February 27, 2019 11:30
@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants