Fix IIssueLabelsClient.RemoveFromIssue()
#1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
release_notes: |
ziranquliu
added a commit
to ziranquliu/octokit.net
that referenced
this pull request
Sep 13, 2018
* 'master' of https://github.com/ziranquliu/octokit.net: Release v0.32 - App-stravaganza! (octokit#1864) provide a Delete<T>() overload that takes a Uri and accept header, but no body (octokit#1868)
nickfloyd
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1865
IIssueLabelsClient.RemoveFromIssue()was incorrectly passing an accept header to the body parameter of the delete call. Recent upstream api changes seem to have occured where this previously ignored situation is now being rejected as the body can't be parsed as valid json. Also the preview functionality for label emojis/descriptions wouldnt have been working on this call due to the accept header not being passed correctly.This PR fixes the issue by adding an overload for
ApiConnection.Delete<T>(Uri uri, string accepts)that takes a Uri and accept header, but no body, which the existing code inRemoveFromIssue()will now use instead ofApiConnection.Delete<T>(Uri uri, object data)