-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement changes to Checks API for Annotations models and re-request endpoint #1857
Conversation
…he changes on github.com as well as still support GHE2.14 add Path and AnnotationLevel fields flag Filename and WarningLevel as deprecated/obsolete also flag BlobHref as deprecated on NewCheckRunAnnotation Adjust ctors to handle new and legacy field options
Add unit and integration tests
I think I've managed to get these changes done to support github.com and also leave the old models/methods intact to continue supporting GHE 2.14 @shiftkey @StanleyGoldman could you cast your 👀 over this just to double check? 🙏 |
…on response and NewCheckRunAnnotation request
release_notes: Implement new/changed fields on |
advisories: Due to upstream breaking changes in the CheckRuns API, using check runs against github.com will require using the new/renamed fields on |
release_notes: Add new method |
…on github.com anyway
Fixes #1856
Attempt to handle both old and new annotations models so we can support github.com and GHE 2.14
Path
andAnnotationLevel
fields toCheckRunAnnotation
response andNewCheckRunAnnotation
requestFilename
andWarningLevel
as deprecated/obsolete but keep them around so we can use them for GHE 2.14BlobHref
as deprecated onNewCheckRunAnnotation
null
so they don't get sent