-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for DateTime serialized as FileTime #1731
Conversation
@itaibh can you provide some more context for this change? Also, this might be worth upstreaming to SimpleJson if it's useful more broadly... |
In some cases GitHub sends wrong date format for the "created_at" and "pushed_at" fields. This is a GitHub bug, probably, but still, such a convention should be supported (and it would have saved me hours of debugging). Back in 2015 there was an open issue on this, which I commented on today, but I can't find it right now. I'm sending this from my phone, and don't have the full attention to provide more info right now. |
@itaibh thanks for the extra info. I found #825 where you commented earlier.
In your other comment you mention this:
If this is a recent regression then I'd love to try and chase this down, because we should be consistent with these fields. If you can point me to a repository which fired a webhook with the wrong format for |
I'm experimenting with web hooks on my own fork of spoon-knife.
I noticed that it happens for some push events.
EDIT: It seems to happen on all push events.
…On Mon, Jan 1, 2018, 23:07 Brendan Forster ***@***.***> wrote:
@itaibh <https://github.com/itaibh> thanks for the extra info. I found
#825 <#825> where you
commented earlier.
This is a GitHub bug, probably, but still, such a convention should be
supported (and it would have saved me hours of debugging).
In your other comment you mention this:
Also, from the timing it seems the problem had returned only recently
(about two weeks ago).
If this is a recent regression then I'd love to try and chase this down,
because we should be consistent with these fields. If you can point me to a
repository which fired a webhook with the wrong format for created_at and
pushed_at in the payload I can chase that up internally and confirm it's
been resolved while we discuss this fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1731 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAImtw4tvzrtwRnZqiVmVWAWM138SbiQks5tGUkSgaJpZM4RQGL1>
.
|
… event payload type.
Merge Adrian Godong work into my master branch.
Status event payload
WIP - added ApplicationClient and related Api Urls.
No description provided.