-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MiscellaneousClient to ApiClient approach and add pagination support to GetAllLicenses. #1716
Update MiscellaneousClient to ApiClient approach and add pagination support to GetAllLicenses. #1716
Conversation
576af11
to
4da7873
Compare
Whoa I didn't even realise we had an ApiClient in the codebase that didn't use the I guess the only thing is that in order to prove these changes are good, we will need integration tests for all the methods in this client, not just the paginated ones 😉 |
8e51c89
to
4da21aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #1716 +/- ##
==========================================
+ Coverage 66.86% 66.94% +0.08%
==========================================
Files 542 542
Lines 14241 14223 -18
==========================================
Hits 9522 9522
+ Misses 4719 4701 -18
|
4da21aa
to
bcd6c1e
Compare
bcd6c1e
to
fdbe099
Compare
release_notes: add pagination support to |
@gdziadkiewicz thanks for getting this going! I decided to push it over the finish line and add in the missing integration tests. If it all goes green now, I'm gonna merge and include it in the next update. |
Fixes #1663
ApiOptions
overloadApiOptions.None
ApiOptions
parameternull
/""
checks forApiOptions
overloads