Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.28 - Get to the Chopper!!! #1709

Merged
merged 2 commits into from
Nov 6, 2017
Merged

Release v0.28 - Get to the Chopper!!! #1709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae6f5b
Update release notes
ryangribble Nov 6, 2017
d61e87d
fix whitespace
ryangribble Nov 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Octokit.Reactive/IObservableGitHubClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public interface IObservableGitHubClient : IApiInfoProvider
/// </remarks>
/// <param name="timeout">The Timeout value</param>
void SetRequestTimeout(TimeSpan timeout);

IObservableAuthorizationsClient Authorization { get; }
IObservableActivitiesClient Activity { get; }
IObservableIssuesClient Issue { get; }
Expand Down
1 change: 0 additions & 1 deletion Octokit.Reactive/ObservableGitHubClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ public IConnection Connection
/// <param name="timeout">The Timeout value</param>
public void SetRequestTimeout(TimeSpan timeout)
{

_gitHubClient.SetRequestTimeout(timeout);
}

Expand Down
2 changes: 1 addition & 1 deletion Octokit/IGitHubClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public interface IGitHubClient : IApiInfoProvider
/// </remarks>
/// <param name="timeout">The Timeout value</param>
void SetRequestTimeout(TimeSpan timeout);

/// <summary>
/// Provides a client connection to make rest requests to HTTP endpoints.
/// </summary>
Expand Down
20 changes: 20 additions & 0 deletions ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
### New in 0.28.0 (released 6/11/2017)

## Advisories and Breaking Changes

- This release has been pushed out in response to `CommitStatus.Id` on GitHub exceeding `Int32.MaxValue`. We've made this field a `long` now... sorry about that!

## Release Notes

**Features/Enhancements**

- You can now use `IGitHubClient.SetRequestTimeout(TimeSpan timeout)` to set a custom timeout, particularly useful for lengthy operations such as uploading release assets. - [#1693](https://github.com/octokit/octokit.net/pull/1693) via [@pmiossec](https://github.com/pmiossec), [@ryangribble](https://github.com/ryangribble)

**Fixes**

- Update `CommitStatus.Id` field from `int` to `long` to prevent overflow exceptions - [#1703](https://github.com/octokit/octokit.net/pull/1703) via [@kzu](https://github.com/kzu)

**Housekeeping**

- Correct rendering of `HttpClient` documentation page - [#1699](https://github.com/octokit/octokit.net/pull/1699) via [@scovetta](https://github.com/scovetta)

### New in 0.27.0 (released 7/10/2017)

## Advisories and Breaking Changes
Expand Down