Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overflow exceptions when status id > int.Max #1703

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Prevent overflow exceptions when status id > int.Max #1703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Octokit/Models/Response/CommitStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class CommitStatus
{
public CommitStatus() { }

public CommitStatus(DateTimeOffset createdAt, DateTimeOffset updatedAt, CommitState state, string targetUrl, string description, string context, int id, string url, User creator)
public CommitStatus(DateTimeOffset createdAt, DateTimeOffset updatedAt, CommitState state, string targetUrl, string description, string context, long id, string url, User creator)
{
CreatedAt = createdAt;
UpdatedAt = updatedAt;
Expand Down Expand Up @@ -57,7 +57,7 @@ public CommitStatus(DateTimeOffset createdAt, DateTimeOffset updatedAt, CommitSt
/// <summary>
/// The unique identifier of the status.
/// </summary>
public int Id { get; protected set; }
public long Id { get; protected set; }

/// <summary>
/// The URL of the status.
Expand Down