-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization membership preview API changes - Review user permission #1633
Merged
ryangribble
merged 12 commits into
octokit:master
from
hnrkndrssn:organization-membership-preview
Jul 29, 2017
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0c81e10
Add organization membership preview header
hnrkndrssn ecc5b2f
Add API endpoints to preview a collaborators permission
hnrkndrssn 72d5919
Add methods to preview a collaborators permission
hnrkndrssn 6d97b81
Add methods to the observable repo collaborator client
hnrkndrssn 486273d
Fix convention test failure
hnrkndrssn 5fed774
Use correct API endpoint when using repository ID
hnrkndrssn 5890395
Move the helper function pair so they aren't in between another pair
hnrkndrssn f28b38a
Use the correct URL for the review permission API endpoint
hnrkndrssn dd2c6d0
Add unit tests
hnrkndrssn 71765c9
Add integration tests for review permission methods
hnrkndrssn c78a1f2
Fix spelling mistake
hnrkndrssn c4bd1b4
Renaming enum as per review
hnrkndrssn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
using System.Diagnostics; | ||
|
||
namespace Octokit | ||
{ | ||
[DebuggerDisplay("{DebuggerDisplay,nq}")] | ||
public class CollaboratorPermission | ||
{ | ||
public StringEnum<CollaboratorPermissions> Permission { get; protected set; } | ||
public User User { get; protected set; } | ||
|
||
internal string DebuggerDisplay => $"User: {User.Id} Permission: {Permission}"; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
using Octokit.Internal; | ||
|
||
namespace Octokit | ||
{ | ||
public enum CollaboratorPermissions | ||
{ | ||
[Parameter(Value = "admin")] | ||
Admin, | ||
[Parameter(Value = "write")] | ||
Write, | ||
[Parameter(Value = "read")] | ||
Read, | ||
[Parameter(Value = "none")] | ||
None | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you get into integration tests I think you'll find the URL for the repositoryId based endpoints is
/repositories/<id>
rather than/repos/<id>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whistling I was just testing you 😉