Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to Milestone class #1489

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Add missing fields to Milestone class #1489

merged 2 commits into from
Oct 13, 2016

Conversation

StanleyGoldman
Copy link
Contributor

Adding missing Milestone fields as per #1358

@ryangribble
Copy link
Contributor

Thanks for the PR 👍

Adding the HtmlUrl is 💎 - this is the url to this milestone on github.com and definitely should be included

But fields like LabelsUrl generally wouldn't be added to octokit.net, since we aim to provide a c# model over the github API, we don't normally expose the internal API hypermedia url links to the end user.

Instead we provide access to the associated API endpoint through the object model, in this case it's at client.Issues.Labels.GetAllForMilestone()

Given the above, are you cool to drop off that labels field from the PR? If not let us know your use case and we can discuss 😀

@StanleyGoldman
Copy link
Contributor Author

Done

@ryangribble
Copy link
Contributor

Sorry for the delay, have been having a bit of no home computer time this week :)

Thanks for the PR!

LGTM

@ryangribble ryangribble merged commit 10d2632 into octokit:master Oct 13, 2016
@StanleyGoldman StanleyGoldman deleted the fixes/missing-data branch October 16, 2016 14:57
@ryangribble ryangribble changed the title Missing Milestone fields Add missing fields to Milestone object Jan 15, 2017
@ryangribble ryangribble changed the title Add missing fields to Milestone object Add missing fields to Milestone class Jan 15, 2017
@ryangribble ryangribble changed the title Add missing fields to Milestone class Add missing fields to Milestone class Jan 15, 2017
@nickfloyd nickfloyd added Type: Feature New feature or request and removed category: feature labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants