Create RepositoryBranchesClient #1437
Conversation
|
Looks like all the tests passing, just needs some 👀 from someone before merging |
|
@ryangribble added to my list |
|
Get in contact with me when you're ready thks
|
| public Task<IReadOnlyList<Branch>> GetAllBranches(string owner, string name) | ||
| { | ||
| Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); | ||
| Ensure.ArgumentNotNullOrEmptyString(name, "name"); | ||
|
|
||
| return GetAllBranches(owner, name, ApiOptions.None); | ||
|
|
There was a problem hiding this comment.
Unnecessary whitespace 😀
|
Other than some superfluous whitespace, this looks good to me 👍 |
|
whitespace fixed, thanks 😀 |
… and EditBranch methods to it, obsoleting the old ones
… RepositoriesClient around for now)
…llBranches, EditBranch methods to it, obsoleting the old ones
ryangribble
force-pushed
the
create-repositorybranches-client
branch
from
df783bc to
7b0acb1
Compare
|
I've run through all the tests locally and it's all 💚 I'm happy with these changes 😁 |
In preparation for #1407 this PR creates a new "Branches" client as a child of "Repositories", inline with the GitHub API layout. Existing branch related methods are moved under this client, with the old methods marked as
[Obsolete]client.Repository.GetBranch()=>client.Repository.Branch.Get()client.Repository.GetAllBranches()=>client.Repository.Branch.GetAll()client.Repository.GetBranch()=>client.Repository.Branch.Edit()Once this is merged, I will work on the new branch protection related methods for #1407