Implement Issue Timeline preview API

[hnrkndrssn]

Adding the Issue Timeline API client as it is now in preview (and we have a need for it for an internal project).

• Timeline API client
• Observable Timeline API client
• XML Doc comments
• Unit tests
• Observable unit tests
• Integration tests
• Observable integration tests
• Repository Id overloads
• Repository Id overload tests
• Paging support
• Paging support tests

Fixes #1436

[hnrkndrssn]

All tests are now passing 🎉 so this is ready for someone to cast their 👀 over 😁

[ryangribble]

This is all looking rather 💎 to me! Ive run the integration tests too 👍

One thing I noticed was a quick count of the "events" listed in the timeline API doc (21) is a couple more than values declared in the EventInfoState enum (19), so is there possibly another couple of values that need to be added to this enum in addition to the cross referenced one you added?

[ryangribble]

Minor nitpick but the doc comments added in this PR have a mix of http and https on the URLs... 😉

[hnrkndrssn]

That's very odd as I'm pretty sure I copied those from the API documentation...I'll fix it and check the docs if there might something pointing to just http.

Ah, the original comment I copied from (in IIssuesEventsClient) has http instead of https...that'll teach me for blindly copy-pasting 😄

[alexander-efremov]

@alfhenrik since version 0.21.1 every "owner/name" method has overload that use repository id instead of owner/name pair. Could you add it in your PR?

@ryangribble not sure, but I think that now every new clients have to have repostoryId overload for each owner/name method, aren't they?

[hnrkndrssn]

Thanks @dampir, I'll add in the necessary overloads and tests

[ryangribble]

@ryangribble not sure, but I think that now every new clients have to have repostoryId overload for each owner/name method, aren't they?

Good pickup, I actualy realised this myself overnight (the things you think about while going to sleep, lol!)

Yes we should be adding repositoryId overload of any method that takes owner/name (as long as it actually works of course!).

I also realised, we should be adding paging support to any GetAllxxx() type methods (ie an overload taking ApiOptions class, with the default method passing ApiOptions.None through to it). Again, assuming paging is actually supported on that end point of course.

[hnrkndrssn]

I also realised, we should be adding paging support to any GetAllxxx() type methods (ie an overload taking ApiOptions class, with the default method passing ApiOptions.None through to it). Again, assuming paging is actually supported on that end point of course.

Looking at the API docs, it doesn't look like the endpoint supports paging, but I'll do some Fiddlering to see if it might actually support it, just being undocumented.

Well, Fiddlering confirms that the endpoint does support paging, I'll add that in as well

[hnrkndrssn]

OK, this should now be good to go

[ryangribble]

Nice work! Everything looking good, ill just pull down your branch and run through the integration tests 👍

[ryangribble]

XmlDoc comment on this function

[hnrkndrssn]

Done

[ryangribble]

I just noticed missing XmlDoc comments on the 2 new functions added to ApiUrls.cs helper class which we probably should add, since every other function in that class has doc tags currently...

Once that's done I'm good to merge 😀

[hnrkndrssn]

Pretty sure that TravisCI failure isn't because of me...looks like that random build failure we've seen before...

[ryangribble]