Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repositoryId overloads to methods on I(Observable)PullRequestReviewCommentReactionsClient #1385

Conversation

alexander-efremov
Copy link
Contributor

As part of my work on #1120 I've added new overloads on I(Observable)PullRequestReviewCommentReactionsClient to get access by repository id.

  • Update XML documentation of interface methods of clients (also synchronize XML docs of IPullRequestReviewCommentReactionsClient and IObservablePullRequestReviewCommentReactionsClient ).

    There is some divergence between XML documentation of methods in IPullRequestReviewCommentReactionsClient and IObservablePullRequestReviewCommentReactionsClient . So I've decided
    to sync XML documentation of these classes during my work on Add support for interacting with repositories by id. #1120.

  • Add overloads to IPullRequestReviewCommentReactionsClient .

    Just add overloads of existing methods that use repositoryId to work with repo.

  • Add overloads to IObservablePullRequestReviewCommentReactionsClient .

    Just add overloads of existing methods that use repositoryId to work with repo.

  • Add unit tests.

    I've added new unit tests that use repositoryId to work with repo that is just a full copy of existing tests that use (owner, name) key.
    Also I've found out that not all methods are covered by tests and added them for new and for old methods.

  • Add integration tests.

    I've added new integration tests that use repositoryId to work with repo that is just a full copy of existing tests that use (owner, name) key.
    I've deleted class ObservablePullRequestReviewCommentReactionsClient Tests beacuse it is useless. All test cases are covered in non-reactive PullRequestReviewCommentReactionsClient Tests class.

/cc @shiftkey, @ryangribble

@alexander-efremov
Copy link
Contributor Author

I've cleared tags here.

@shiftkey shiftkey self-assigned this Jun 30, 2016
@shiftkey
Copy link
Member

Tests are good. Just need to remove the empty <returns></returns> elements.

@alexander-efremov
Copy link
Contributor Author

@shiftkey done!

@shiftkey shiftkey merged commit 3032c74 into octokit:master Jul 6, 2016
@alexander-efremov alexander-efremov deleted the add-repo-id-pull-request-review-comment-reactions-client branch July 6, 2016 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants