User GPG Keys client #1343
Merged
User GPG Keys client #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrkndrssn
force-pushed
the
enh-gpgkeysclient
branch
from
2f65887 to
84303dd
Compare
| /// </remarks> | ||
| public IObservableUserGpgKeysClient GpgKeys { get; private set; } | ||
|
|
||
|
|
There was a problem hiding this comment.
Extra whitespace line? (Nitpick, I know!!)
|
Looks good! I've made a few comments |
|
Thanks @ryangribble, I've pushed fixes for your comments. |
hnrkndrssn
force-pushed
the
enh-gpgkeysclient
branch
from
24043fc to
9cf42fe
Compare
|
sorry @alfhenrik , this just needs a rebase/merge due to some other PR's I merged (probably just |
|
No problem, I'll do that soon |
hnrkndrssn
force-pushed
the
enh-gpgkeysclient
branch
from
9cf42fe to
9e594a6
Compare
|
Rebased and ready for review again |
|
Cool, I just sent a PR to your branch to bring your also found the integration tests you added were failing sometimes... turned out there was a missing |
Context helper tweaks and fix integration test
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IUserGpgKeysClient.csandUserGpgKeysClient.csApiUrls.GpgKeysNewGpgKeyrequest modelGpgKeyresponse modelIObservableUserGpgKeysClient.csandObservableUserGpgKeysClient.csUserGpgKeysClientTests.csObservableUserGpgKeysClientTests.csUserGpgKeysClientTests.csObservableUserGpgKeysClientTests.csFixes #1252