Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApiOptions overloads to methods on I(Observable)RepositoryDeployKeysClient #1307

Merged
merged 7 commits into from
May 20, 2016

Conversation

alexander-efremov
Copy link
Contributor

@alexander-efremov alexander-efremov commented May 20, 2016

Refer #1175 .

To-do:

  • Add overload Task> GetAll(ApiOptions options) on IRepositoryDeployKeysClient.
  • Add overload IObservable GetAll(ApiOptions options) on IObservableRepositoryDeployKeysClient.
  • Add unit tests for these new methods.
  • Add integration tests for these new methods.
    I've implemented the integration tests, but they are skipped now, because we don't have opportunity generate ssh keys in C# code (Review CanRetrieveAllDeployKeys test #1003).
    Also I haven't implemented integration tests for ObservableRepositoryDeployKeysClient because internally ObservableRepositoryDeployKeysClient use RepositoryDeployKeysClient that have integration tests already (just they skipped 😄 ).

/cc @shiftkey , @ryangribble

@alexander-efremov
Copy link
Contributor Author

@shiftkey, @ryangribble please review these PR whenever possible, it's done.

@alexander-efremov alexander-efremov changed the title [WIP] Add ApiOptions overloads to methods on I(Observable)RepositoryDeployKeysClient Add ApiOptions overloads to methods on I(Observable)RepositoryDeployKeysClient May 20, 2016
@shiftkey
Copy link
Member

@dampir 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants