Fix usage of FormatUri method #1290
Conversation
alexander-efremov
changed the title
|
Could anybody merge it if there is no problems? /cc @shiftkey, @ryangribble |
This reverts commit f47405f.
fixed usage of "repos/{0}/{1}/stats/contributors".FormatUri(owner, repositoryName)
fixed usage of "repos/{0}/{1}/stats/commit_activity".FormatUri(owner, repositoryName)
fixed usage of "repos/{0}/{1}/stats/code_frequency".FormatUri(owner, name)
fixed usage of "repos/{0}/{1}/stats/participation".FormatUri(owner, name)
fixed usage of "repos/{0}/{1}/stats/punch_card".FormatUri(owner, name)
fixed documentation
fixed usage of "repos/{0}/{1}/collaborators/{2}".FormatUri(owner, repo, user)
fixed usage of"orgs/{0}/members/{1}".FormatUri(org, user)
fixed usage of "orgs/{0}".FormatUri(organizationName)
* Fix inconsistecy in parameters name that used in methods that use "repos/{0}/{1}" syntax.
* added XML documentation for PullRequestFiles method
* updated XML documentation of some methods in ApiUrls
* added needed XML doc tags
* fixed name of parameter
* fixed name of parameter
* undo prev. commit
alexander-efremov
force-pushed
the
fix-usage-of-format-uri
branch
from
8147459 to
23191be
Compare
|
The builds failed after recent rebase? |
|
@ryangribble yes and don't have any suspicions why it failed... I've figured out - OrganizationMembersClient.cs is missed during rebase I don't know why 😵 |
|
looks like |
alexander-efremov
force-pushed
the
fix-usage-of-format-uri
branch
from
c8b45b4 to
e45f8e0
Compare
|
Hope it is fixed in the last commit. Merge/rebase always makes my cry 😢 |
| @@ -207,6 +207,10 @@ | |||
| </CodeAnalysisDictionary> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <ProjectReference Include="..\Octokit\Octokit-Mono.csproj"> | |||
There was a problem hiding this comment.
This reference isn't necessary
There was a problem hiding this comment.
Yep, fixed!
| @@ -1,6 +1,10 @@ | |||
| using System; | |||
| using System.Collections.Generic; | |||
There was a problem hiding this comment.
I'm not sure why these using statements are needed
There was a problem hiding this comment.
I removed all unused usings in the file.
|
@dampir a couple of unnecessary introduced changes, but aside from that this looks good. ❤️ seeing the inlined URLs being extracted! |
Without it I can't properly generate new urls to access API by repo id 😄 |
As part of my work on #1120 I've done some improvements in ApiUrls.cs class.
I've found out that not all clients use ApiUrls to build Uri and get right API endpoint. As far it is directly connected with my work, I fixed these cases.
/cc @shiftkey, @ryangribble