Add custom exception for the HTTP 451 response #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devkhan just added a task to ensure the files are synced across all the projects |
|
@ryangribble The Travis Linux build is failing. Can you please review? |
| [Fact] | ||
| public void HasDefaultMessage() | ||
| { | ||
| var response = new Response(HttpStatusCode.Forbidden, null, new Dictionary<string, string>(), "application/json"); |
There was a problem hiding this comment.
Shouldnt the status code here be the HTTP 451 (not Forbidden?)
There was a problem hiding this comment.
I'm really sorry for this, I'll fix this. Thanks.
There was a problem hiding this comment.
No need to apologosie! Everyone's contributions are much appreciated 😀
shiftkey
changed the title
|
LGTM 👍 |
|
Should I add some integration tests using one of the repos from http://github.com/github/dmca ? |
|
@devkhan don't worry about it. I think this area of the codebase is rather boring and unit tests are good enough coverage for the error code handling... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1237.
As per this blog post.
GitHub API will now return a HTTP 451 response (rather than a 403) when a repository or gist cannot be accessed due to a DMCA notice.
Checklist:
HandleErrors..\build FixProjects/cc @ryangribble