Add "importers" field to MiscellaneousClient.Meta response #1235
Conversation
Implement unit test for GetMetadata() call Flesh out integration test to check all returned Meta fields -> Found and fixed a bug where the existing `GitHubServicesSHA` field was not deserialised properly
Fix observable's constructor (obsoleting old constructor) to make it consistent with the other API clients
ryangribble
changed the title
importers field to meta response in MiscellaneousClient
ryangribble
changed the title
importers field to meta response in MiscellaneousClientmeta response in `MiscellaneousClient
ryangribble
changed the title
meta response in `MiscellaneousClient
| @@ -9,6 +9,7 @@ public class ObservableMiscellaneousClient : IObservableMiscellaneousClient | |||
| { | |||
| readonly IMiscellaneousClient _client; | |||
|
|
|||
| [Obsolete("Please use another constructor")] | |||
There was a problem hiding this comment.
Let's make this really specific - what about something like: [Obsolete("Please use the IGitHubClient overload constructor")]
It's weird that this is failing - the UpperCamelCase to upper_camel_case looks like it should work here but perhaps I'm missing something. Anyway, happy to take this in here... |
|
@ryangribble this all seems great ✨ just the little message which is really, really minor |
I think the capital H in "GitHub" was causing it to be looking for But yeah in any case, it was |
Ah yes, that makes sense 💀 |
|
|
nickfloyd
added
Type: Bug
Adds new field "Importers" to the Metadata request of MiscellaneousClient
API docs: https://developer.github.com/v3/meta/
Fixes #1234
Importersfield toMetaresponse model and updatedctorGetMetadatamethodGetMetadatamethodGitHubServicesShanot being deserialised properly, added a fix to this PRObservableMiscellaneousClientfor all methodsNo tests for this observable client existed, so all methods were implemented
ObservableMiscellaneousClientconstructor to be inline with all other obersvable API clients(Marked old constructor as
[Obsolete]so it can be removed in a later release)