Cleanup obsolete items

[M-Zuber]

per #1194 (specifically this comment)

• one small item to draw attention to is this question

[ryangribble]

one small item to draw attention to is this question

As per my reply on #1194 I suggest we should just 🔥 the ApiExtensions.GetRedirect() method

[M-Zuber]

@ryangribble done

[ryangribble]

Oops, it looks like there is one more reference in ApiConnection and IApiConnection with GetRedirect()

The problem is, the concrete implementation was made obsolete 111 days ago, but the interface member hasnt been marked obsolete at all! 😭

But if we have to keep this, then it means we have to keep the ApiExtension one around as well, but that seems kinda pointless since the GetRedirect() will never actually get a HTTP 302 response anyway and thus will always throw an exception

@shiftkey what do you reckon to 🔥ing IApiConnection.GetRedirect(), eventhough it wasnt marked obsolete? Note that the concrete implementation, as well as multiple other places regarding Redirects and ArchiveLinks HAVE been obsolete for 100+ days

[M-Zuber]

😭
That's what I get for pushing my machines RAM too hard. The error in VS hadn't show up by the time the commit was pushed....

I'll wait for @shiftkey's response (may have to wait until after #build 😄 ) and follow his recommendation

[shiftkey]

@ryangribble

what do you reckon to 🔥ing IApiConnection.GetRedirect(), eventhough it wasnt marked obsolete? Note that the concrete implementation, as well as multiple other places regarding Redirects and ArchiveLinks HAVE been obsolete for 100+ days

I'd be breaking my own rule here, and covering over an oversight of mine. Let's add the [Obsolete] to the interface and leave it alone for this release.

[ryangribble]

so @M-Zuber just chasing up on this one, I take it you are good to rebase to latest master and also tackle the redirect methods according to @shiftkey's comments

[M-Zuber]

I'm good to do the work, but on the road ATM.
Will attempt to get to it in the next day or two

[M-Zuber]

@shiftkey @ryangribble rebased and updated code with regards to .GetRedirect.
Would love if I could get some 👀 on the changes to make sure that the changes are correct.

[shiftkey]

This all seems good to me. @ryangribble anything else to add here?

[ryangribble]

All good! I love that feeling of cleaning things up 😀

[ryangribble]