Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistency in GistsClientTests #1199

Merged

Conversation

alexander-efremov
Copy link
Contributor

As was mentioned here

#1190 (diff)

Consistency is our friend! So, this PR intends to fix inconsistency a little bit.

/cc @ryangribble

@alexander-efremov
Copy link
Contributor Author

Tests for Linux (Mono) aren't passed for some reasons...

@ryangribble
Copy link
Contributor

Tests for Linux (Mono) aren't passed for some reasons...

Unfortunately there are some sporadic TravisCI failures... we are tracking them here: #1076

I kicked it off again and has passed now. Thanks for your efforts in getting things nicely consistent in the codebase!

LGTM

ryangribble added a commit that referenced this pull request Mar 19, 2016
@ryangribble ryangribble merged commit a74cbe7 into octokit:master Mar 19, 2016
@alexander-efremov alexander-efremov deleted the fix-inconsistency-gistclienttest branch March 21, 2016 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants