IUserKeysClient.GetAll -> GetAllForCurrent()

[M-Zuber]

Fixes #1136

[ryangribble]

Just me being pedantic, but now the method has been renamed, can we also please rename the unit test classes?

eg class TheGetAllMethod should now be class TheGetAllForCurrentMethod here and here

Also AppVeyor build seems to be throwing a Code Analysis CA1024 error

MSBUILD : error CA1024: Microsoft.Design : Change 'IUserKeysClient.GetAllForCurrent()' to a property if appropriate. [C:\projects\octokit-net\Octokit\Octokit.csproj]

Im not sure why the method name GetAlldidnt trigger it but GetAllForCurrentdoes, but you can suppress it (varoius examples through the codebase like here

[shiftkey]

can we also please rename the unit test classes?

👍

Im not sure why the method name GetAll didnt trigger it but GetAllForCurrentdoes, but you can suppress it

I forget the exact reasons, but I gather FxCop just doesn't like methods without parameters (even though these return something more complex than a value)...

EDIT: nevermind, MSDN has my back:

A public or protected method has a name that starts with Get, takes no parameters, and returns a value that is not an array.

[ryangribble]

That doesn't explain why it didn't trip the error previously when called GetAll though does it?

[shiftkey]

@ryangribble it does not, no...

[ryangribble]

Hmm the build failures look like they couldn't talk to nuget.org at the time...

I kicked off the Travis build again and that's now passed. Don't think I have access to do the same on Appveyor @haacked @shiftkey

[shiftkey]

@ryangribble I'm on it

[shiftkey]

This all looks good to me. I'll let @ryangribble hit the big green button on it (it won't go out in v0.19, but that's a minor thing).

[ryangribble]

[shiftkey]

release_notes: Renamed IUserKeysClient.GetAll() to IUserKeysClient.GetAllForCurrent()