StatisticsClient should not clobber /api/v3/ in path #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
changed the title
shiftkey
force-pushed
the
relative-paths-statistics
branch
from
3ca48cb to
3d7a20c
Compare
shiftkey
changed the title
|
Gotta rebase once #1087 is merged |
… slash). This was one of the cases we didn't notice, and so it causes the StatisticsClient to drop the /api/v3/ prefix that GitHub Enterprise requires to route things correctly.
shiftkey
force-pushed
the
relative-paths-statistics
branch
from
3d7a20c to
4384992
Compare
|
Ready for review |
|
Nice catch! |
haacked
added a commit
that referenced
this pull request
Feb 4, 2016
StatisticsClient should not clobber /api/v3/ in path
|
We should do a Roslyn analyzer to not allow absolute (attempted nerd snipe) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #822
All other routes - e.g.
ApiUrls- are defined without a leading slash.Except these. This fixes that.