Implement GitHub Enterprise License and Organization API's #1073
Conversation
ryangribble
force-pushed
the
enterprise-api
branch
from
ad64061 to
751697e
Compare
- Remove EnterpriseUrl in integration test Helper class, but leave ability to override custom URL (to allow specific use case of targetting regular integration tests at a custom URL) - Move GitHub Enterprise explicit support to a new integration helper class using new OCTOKIT_GHE_ environment variables for GHE - Change existing GitHub Enterprise integration tests and EnterpriseTestAttribute to use the new EnterpriseHelper methods - Enhance configure-intergration-tests.ps1 script to cater for environment variable changes
ryangribble
force-pushed
the
enterprise-api
branch
from
751697e to
e46abc8
Compare
|
I've rebased this now that the AdminStats PR #1049 has been merged so it should be good for review/merge! |
|
|
||
| namespace Octokit.Tests.Integration | ||
| { | ||
| public static class EnterpriseHelper |
|
@ryangribble this is so good!
Just a few conceptual questions about the |
|
Looks like the Travis build failure is unrelated, @shiftkey ? |
|
Did the travis build automatically retry or did someone kick it off again? Is there any way (apart from pushing another commit) for plebs to get the builds to try again? 😀 |
Nope, it was me.
I'm afraid not. We're looking into the Mono issues and where they might be hiding, but that's going to take some time. I'll keep an eye on the build state as part of reviewing - if you're happy that the error isn't your fault just comment so I know you've looked at it. |
|
Hey @shiftkey not sure if you may have forgotten about this one, but ive pulled latest master over again and the builds are still passing. Should be ready for a LGTM 👅 |
| string orgName = String.Concat(orgLogin, " Display Name"); | ||
|
|
||
| var newOrganization = new NewOrganization(orgLogin, EnterpriseHelper.UserName, orgName); | ||
| var observable = _github.Enterprise.Organization.Create(newOrganization); |
There was a problem hiding this comment.
Is it worth doing any cleanup here after creating the organization?
There was a problem hiding this comment.
Of course as soon as I realised that I should read the documentation I realise that "there's no endpoint". So that's a pretty good reason to not do that. Nevermind.
|
I'm gonna take this in without that bit of 💄. Thanks @ryangribble!
|
Implement GitHub Enterprise License and Organization API's
Status
🚀Ready to merge🚀
Enhance integration test support for GitHub Enterprise
TattsGroup@535709c
Added a new EnterpriseHelper class for creating enterprise clients, using a new set of environment variables for this purpose. Enhanced the powershell script to assist in setting up these GitHub Enterprise integration test variables if desired
Implement Enterprise License Client
https://developer.github.com/v3/enterprise/license/
Fixes #1023
Includes normal and reactive implementations plus unit and integration tests for both
Implement Enterprise Organization Client
https://developer.github.com/v3/enterprise/orgs/
Fixes #1025
Includes normal and reactive implementations plus unit and integration tests for both
Tests
Obviously the integration tests require a GitHub enterprise instance so wont run as part of Octokit builds currently. Integration tests are passing on my GHE instance