-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement user Administrator Client #1068
Conversation
@paladique just some xml-docs changes which are making CI cry currently:
|
Fixed incorrect comment param tag.
Hmm, looks like |
Also the convention test are failing because of observables.
|
You're right. This somehow slipped through the initial PR passing CI https://github.com/octokit/octokit.net/pull/1061/files#r50933117 - but the fix 5ca6633 is now in master. Perhaps this branch was created before, in which case a merge or cherry-pick should pull in the fix... |
@paladique you could merge master into your branch and push. Or, if you're feeling adventurous, rebase your branch against master and force push to this branch. |
Great work @paladique, and thanks for the contribution! |
Implement user Administrator Client
🎉 |
Per, #1030. All implemented tests are passing.