Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SHA property to MergePullRequest #804

Closed
hnrkndrssn opened this issue May 18, 2015 · 5 comments · Fixed by #805
Closed

Add SHA property to MergePullRequest #804

hnrkndrssn opened this issue May 18, 2015 · 5 comments · Fixed by #805
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@hnrkndrssn
Copy link
Contributor

The API caters for specifying the SHA that pull request head must match to allow merge, but the MergePullRequest model does not, we should add this so that it can be passed in when trying to merge a PR.
@shiftkey
Copy link
Member

👍

@shiftkey
Copy link
Member

Also, we should confirm that message is actually optional while we're in there...

@hnrkndrssn
Copy link
Contributor Author

Since I want need this, I'll send a PR for it

@hnrkndrssn hnrkndrssn mentioned this issue May 19, 2015
Merged
@shiftkey
Copy link
Member

@alfhenrik it's now available in v0.12 on NuGet.

@hnrkndrssn
Copy link
Contributor Author

Champion! Thanking you very much 🍰

From: Brendan Forstermailto:[email protected]
Sent: ‎19/‎05/‎2015 18:55
To: octokit/octokit.netmailto:[email protected]
Cc: Henrik Anderssonmailto:[email protected]
Subject: Re: [octokit.net] Add SHA property to MergePullRequest (#804)

@alfhenrik it's now available in v0.12 on NuGet.

Reply to this email directly or view it on GitHub:
#804 (comment)

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SHA and make message optional for pull request merge hnrkndrssn/octokit.net
3 participants
@nickfloyd @shiftkey @hnrkndrssn