Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors #790

Closed
M-Zuber opened this issue Apr 27, 2015 · 5 comments
Closed

Colors #790

M-Zuber opened this issue Apr 27, 2015 · 5 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@M-Zuber
Copy link
Contributor

M-Zuber commented Apr 27, 2015

I know that the official api returns colors without the leading # but what do you think about adding it in? In most use cases in C# it is useful to necessary to have it
@shiftkey
Copy link
Member

I'm indifferent on this as it's not something I use day-to-day. But if there's sufficient interest in this use case I would be happy to review a contribution about it....

@M-Zuber
Copy link
Contributor Author

M-Zuber commented Apr 27, 2015

I've been thinking about this some more and am starting to lean towards just providing a warning in the doc - comments.
But I will leave this open in case a discussion develops

@shiftkey
Copy link
Member

@M-Zuber 👍 to clarifying the docs as a good first step

@M-Zuber
Copy link
Contributor Author

M-Zuber commented Jun 18, 2015

is this the correct spot to put it in?

SeanKilleen added a commit to SeanKilleen/octokit.net that referenced this issue Jan 9, 2017
@SeanKilleen
Update label docs to reflect color information
c411d91 
Resolves octokit#790
@SeanKilleen SeanKilleen mentioned this issue Jan 9, 2017
Merged
@SeanKilleen
Copy link
Contributor

I took a quick stab at this in #1530.

ryangribble pushed a commit that referenced this issue Jan 9, 2017
@SeanKilleen @ryangribble
Add docs snippet for label coloring (#1530)
3a1070f 
* Update label docs to reflect color information

Resolves #790

* Clarify doc language

Because I couldn't just have a one-commit PR. No, that'd be too easy.

* Futher clarification

I guess we might as well make it right.
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nickfloyd @shiftkey @SeanKilleen @M-Zuber