WatchersCount on repository incorrect

[DaveWM]

It looks like the WatchersCount property is set incorrectly on the repository object, it's always the same as the StargazersCount property. For example, it is showing as 605 for this repo when it should be 80. Will submit a PR for this when I have time :).

[shiftkey]

@DaveWM I think this is actually a bug in the GitHub API - https://api.github.com/repos/octokit/octokit.net

cc @pengwynn

[pengwynn]

It's confusing but that's expected, because history.

You'll find what the UI calls "Watchers" in the subscribers_count field for API resources.

[shiftkey]

@pengwynn thanks for the details

[DaveWM]

@shiftkey @pengwynn Thanks guys :)

[haacked]

@shiftkey @DaveWM if I understand this correctly, it seems like we should remove the deprecated property from our client API. I'm guessing WatchersCount can go away as long as we have a SubscribersCount property?

[shiftkey]

@haacked gah, you're right - we can still fix this.

We could map subscribers_count to WatchersCount instead of deprecating the property altogether. How does that feel?

[haacked]

I'd rather have the property name match the api field name as much as possible. We're not 1.0 yet, we can do whatever the hell we want. 😛 Let's just match the API canonical names.

[shiftkey]

Fiiiiine 😛

[haacked]

😛 It's just my preference. I think it's a good rule of thumb. But I'm open to strong arguments to the contrary in specific cases. 😄

[haacked]

Also, if we're all in agreement, would you like to submit a PR with this change @DaveWM?

[shiftkey]

It's just my preference. I think it's a good rule of thumb.

I'm just being pre-caffeine silly here. As the behaviour isn't going to change for the lifetime of v3, I'm 👍 with hiding away this incorrect field.

[DaveWM]

@haacked @shiftkey I've made a PR (#701), just removed the WatchersCount property. Probably a good idea to remove this even though it's still on the api, just to avoid confusion