Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Missing APIOption overload for PackagesClient.GetAll* #2923

Closed
1 task done
lars-zweifel opened this issue May 30, 2024 · 1 comment · Fixed by #2934
Closed
1 task done

[FEAT]: Missing APIOption overload for PackagesClient.GetAll* #2923

lars-zweifel opened this issue May 30, 2024 · 1 comment · Fixed by #2934
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@lars-zweifel
Copy link
Contributor

Describe the need

The Packages API Endpoint now uses Pagination to get Packages which limits the request to 30 Results.
There should be an APIOption overload for the following Methods:

  • GetAllForOrg
  • GetAllForActiveUser
  • GetAllForUser

SDK Version

v11.0.1

API Version

GitHub REST API 2022-11-28

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lars-zweifel lars-zweifel added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels May 30, 2024
@lars-zweifel
Copy link
Contributor Author

Since we need this feature I'm happy to work on it.

lars-zweifel added a commit to lars-zweifel/octokit.net that referenced this issue May 31, 2024
@lars-zweifel
feat: added Missing APIOption overload for PackagesClient.GetAll* oc…
4d58ce5 
…tokit#2923

added missing APIOption overload for PackagesClient and ObservablePackagesClient
added overload for optional parameter packageVisibility to be a nonbreaking change
extended PackagesClientTests.cs to be conform with RepositoriesClientTests.cs to take ApiOptions into account
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Jun 3, 2024
@nickfloyd nickfloyd moved this from 🆕 Triage to 🔥 Backlog in 🧰 Octokit Active Jun 3, 2024
@lars-zweifel lars-zweifel mentioned this issue Jun 18, 2024
Merged
4 tasks
kfcampbell pushed a commit that referenced this issue Jun 21, 2024
@lars-zweifel
feat: added Missing APIOption overload for PackagesClient.GetAll* #2923
bdc1694 
 (#2934)

feat: added Missing APIOption overload for PackagesClient.GetAll* #2923

added missing APIOption overload for PackagesClient and ObservablePackagesClient
added overload for optional parameter packageVisibility to be a nonbreaking change
extended PackagesClientTests.cs to be conform with RepositoriesClientTests.cs to take ApiOptions into account
@github-project-automation github-project-automation bot moved this from 🔥 Backlog to ✅ Done in 🧰 Octokit Active Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added Missing APIOption overload for PackagesClient.GetAll* #2923 lars-zweifel/octokit.net
2 participants
@nickfloyd @lars-zweifel