Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid exception when add-collaborator return 201 #2558

Closed
FrediKats opened this issue Sep 3, 2022 · 4 comments · Fixed by #2559
Closed

Invalid exception when add-collaborator return 201 #2558

FrediKats opened this issue Sep 3, 2022 · 4 comments · Fixed by #2559

Comments

@FrediKats
Copy link
Contributor

From docs (https://docs.github.com/en/rest/collaborators/collaborators#add-a-repository-collaborator):

image

But .Add method has response.HttpResponse.IsTrue() and fail on 201. Method should return RepositoryInvitation instead of bool and do not fail on 201.

@timrogers
Copy link
Contributor

Thanks for reporting this issue! Would you be open to creating a PR to fix it? We welcome all contributions ❤️

@FrediKats
Copy link
Contributor Author

We will try to fix it.

@timrogers
Copy link
Contributor

If you don't have time or if you run into any issues, let us know and we can try to pick this up on our side.

I imagine this will end up being a breaking change as the return type will be different.

@annchous
Copy link
Contributor

annchous commented Sep 3, 2022

This issue was originally posted in #2373, but the author had lost the confirmation of this problem somehow.

I can try to create a pull request to fix it in a few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants