Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RepoCollaboratorsClient.Add throws exception with 201 status code (Created) #2373

Closed
marwie opened this issue Nov 16, 2021 · 3 comments · Fixed by #2559
Closed

RepoCollaboratorsClient.Add throws exception with 201 status code (Created) #2373

marwie opened this issue Nov 16, 2021 · 3 comments · Fixed by #2559
Labels
Type: Bug Something isn't working as documented

Comments

@marwie
Copy link

marwie commented Nov 16, 2021

Hello, looks like github changed the return code for adding collaborators

STRP:

  1. check "IsCollaborator"
  2. if false call "Add"
  3. observe exception

Using octokit 0.50.0

image

@nickfloyd nickfloyd added the bug label Apr 25, 2022
@JonruAlveus
Copy link
Collaborator

@nickfloyd this check is only performed when there is a CollaboratorRequest passed in. This appears to be organisation-owned/enterprise only. Unfortunately I don't have access to test this, do you? RepoCollaboratorsClient.Add methods.

@nickfloyd
Copy link
Contributor

@JonruAlveus Thanks for the heads up on this. I've added it to the board to put some 👀's on it soon to verify and fix.

@JonruAlveus
Copy link
Collaborator

Hi @marwie, could you confirm if this is still occurring? I can't now reproduce it.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants