Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeployTask should be a string, not an enum #2412

Closed
mryanmurphy opened this issue Feb 14, 2022 · 0 comments · Fixed by #2413
Closed

DeployTask should be a string, not an enum #2412

mryanmurphy opened this issue Feb 14, 2022 · 0 comments · Fixed by #2413
Labels
Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request

Comments

@mryanmurphy
Copy link
Contributor

Per docs and actual usage, there is no way to enumerate all possible values of task. It's an arbitrary string that only has meaning given to it via the consuming deployment mechanism. The example values are truly examples, not the only accepted values.

The task parameter is used by the deployment system to allow different execution paths. In the web world this might be deploy:migrations to run schema changes on the system. In the compiled world this could be a flag to compile an application with debugging enabled.

https://docs.github.com/en/rest/reference/deployments#create-a-deployment

public DeployTask Task { get; set; }

mryanmurphy added a commit to mryanmurphy/octokit.net that referenced this issue Feb 15, 2022
@nickfloyd nickfloyd added Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request and removed category: breaking-change labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants