Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OauthClient.CreateAccessToken calls incorrect URL for Enterprise instances #1729

Closed
grapehunter opened this issue Dec 28, 2017 · 1 comment
Closed

OauthClient.CreateAccessToken calls incorrect URL for Enterprise instances #1729

grapehunter opened this issue Dec 28, 2017 · 1 comment

Comments

@grapehunter
Copy link

grapehunter commented Dec 28, 2017 •
edited
Loading

Another issue about enterprise address refer to #1724
[AS-IS]
https://enterprise.url/api/v3/login/oauth/access_token
[SHOULD-BE]
https://enterprise.url/login/oauth/access_token

By the way,please take serveral minutes to check all address of enterprise, it's a horrible disaster
@grapehunter grapehunter reopened this Dec 28, 2017
@ryangribble
Copy link
Contributor

Hi @grapehunter I've updated PR #1726 to fix the CreateAccessToken url, does that look good to you?

By the way,please take serveral minutes to check all address of enterprise, it's a horrible disaster

Do you have any other examples? I use octokit against our GHE instance and haven't found any incorrect url's with the methods I'm calling...

@ryangribble ryangribble mentioned this issue Dec 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grapehunter @ryangribble