You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OauthClient.GetGitHubLoginUrl with an enterprise instance URL of https://example.com should return e.g. https://example.com/login/oauth/authorize?client_id=secret, and indeed that is what the unit tests are testing.
In real usage, however, connection.BaseAddress will return a URL like https://example.com/api/v3/ meaning that the returned URL will be https://example.com/api/v3/login/oauth/authorize?client_id=secret - this URL is wrong.
The text was updated successfully, but these errors were encountered:
OauthClient.GetGitHubLoginUrl
with an enterprise instance URL ofhttps://example.com
should return e.g.https://example.com/login/oauth/authorize?client_id=secret
, and indeed that is what the unit tests are testing.In real usage, however,
connection.BaseAddress
will return a URL likehttps://example.com/api/v3/
meaning that the returned URL will behttps://example.com/api/v3/login/oauth/authorize?client_id=secret
- this URL is wrong.The text was updated successfully, but these errors were encountered: