Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OauthClient.GetGitHubLoginUrl returns incorrect URL for Enterprise instances. #1724

Closed
grokys opened this issue Dec 7, 2017 · 0 comments · Fixed by #1726
Closed

OauthClient.GetGitHubLoginUrl returns incorrect URL for Enterprise instances. #1724

grokys opened this issue Dec 7, 2017 · 0 comments · Fixed by #1726
Labels
Type: Bug Something isn't working as documented

Comments

@grokys
Copy link
Contributor

grokys commented Dec 7, 2017

OauthClient.GetGitHubLoginUrl with an enterprise instance URL of https://example.com should return e.g. https://example.com/login/oauth/authorize?client_id=secret, and indeed that is what the unit tests are testing.

In real usage, however, connection.BaseAddress will return a URL like https://example.com/api/v3/ meaning that the returned URL will be https://example.com/api/v3/login/oauth/authorize?client_id=secret - this URL is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants