Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue Comments - need an overload to take in optional arguments #1500

Closed
shiftkey opened this issue Nov 9, 2016 · 1 comment
Closed

Issue Comments - need an overload to take in optional arguments #1500

shiftkey opened this issue Nov 9, 2016 · 1 comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

shiftkey commented Nov 9, 2016

Documentation: https://developer.github.com/v3/issues/comments/#list-comments-in-a-repository

Existing methods: https://github.com/octokit/octokit.net/blob/master/Octokit/Clients/IIssueCommentsClient.cs#L36-L66

There should be overloads for each of these methods which accept an parameter which IssueCommentRequest and has those fields from the documentation.
@pjc0247 pjc0247 mentioned this issue Nov 11, 2016
Merged
@ryangribble ryangribble mentioned this issue Nov 18, 2016
Closed
ryangribble pushed a commit that referenced this issue Jan 7, 2017
@pjc0247 @ryangribble
Fix IssueCommentClient #1500 (#1501)
cf0eddd 
* Make GetAllForRepo to accept optional args

* Fix tests

* add missing interfaces

* fix tests

* Fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* fix

* fix tests

* fix tests
@SeanKilleen
Copy link
Contributor

I believe this is now closed via #1501.

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nickfloyd @shiftkey @SeanKilleen @ryangribble