Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark RepositoryFormatException.GetObjectData with System.Security.SecurityCritical #1471

Closed
khellang opened this issue Sep 22, 2016 · 1 comment

Comments

@khellang
Copy link
Contributor

I'm getting this exception when trying to run a program using Octokit in .NET Fiddle:

[System.TypeLoadException: Inheritance security rules violated while overriding member: 'Octokit.RepositoryFormatException.GetObjectData(System.Runtime.Serialization.SerializationInfo, System.Runtime.Serialization.StreamingContext)'. Security accessibility of the overriding method must match the security accessibility of the method being overriden.]
at Program.d__5.MoveNext(): line 57

[System.AggregateException: One or more errors occurred.]
at Program.Main(String[] args): line 16

I think RepositoryFormatException.GetObjectData should be annotated with System.Security.SecurityCritical, like its base version.

I'll PR this if no one beats me to it 😄

@khellang khellang changed the title Mark Mark RepositoryFormatException.GetObjectData with System.Security.SecurityCritical Sep 22, 2016
M-Zuber added a commit to M-Zuber/octokit.net that referenced this issue Oct 13, 2016
@M-Zuber
Copy link
Contributor

M-Zuber commented Oct 13, 2016

Beat you to it 😃

M-Zuber added a commit to M-Zuber/octokit.net that referenced this issue Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants